Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error on GCC-9 #3093

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix build error on GCC-9 #3093

merged 2 commits into from
Sep 12, 2022

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Sep 10, 2022

Issue: #3092

@phprus phprus marked this pull request as draft September 10, 2022 22:12
@phprus phprus marked this pull request as ready for review September 10, 2022 22:49
@phprus
Copy link
Contributor Author

phprus commented Sep 11, 2022

@vitaut
I think it is necessary to add a GCC-9 compiler to CI for testing fmt on all current versions of GCC.

@vitaut
Copy link
Contributor

vitaut commented Sep 11, 2022

LGTM but please rebase since there were some changes to write_loc.

@phprus
New CI: GCC-9
b8d731f 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
Fix build error on GCC-9
4fd2d0a 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
Copy link
Contributor Author

phprus commented Sep 11, 2022

@vitaut
Rebased

@vitaut vitaut merged commit 61844b6 into fmtlib:master Sep 12, 2022
@vitaut
Copy link
Contributor

vitaut commented Sep 12, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phprus @vitaut