Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gcc <= 7.1 compile errors #3097

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix gcc <= 7.1 compile errors #3097

merged 1 commit into from
Sep 12, 2022

Conversation

sergiud
Copy link
Contributor

@sergiud sergiud commented Sep 11, 2022

Fixes #3096

@sergiud sergiud force-pushed the gcc-7.1-and-below-compile-errors branch 2 times, most recently from fbfd2af to 0668ed6 Compare September 11, 2022 23:20
@mwinterb
Copy link
Contributor

Adding FMT_CONSTEXPR to the constructors for scan_handler, scan_context, scan_args, and scan_arg (and initializing int_value to nullptr for the default) also seemed to fix compilation going back to the first version that FMT_USE_CONSTEXPR is defined for, GCC 6.1. That seems cleaner. https://godbolt.org/z/oncnxz9nc

@sergiud sergiud force-pushed the gcc-7.1-and-below-compile-errors branch from 0668ed6 to dba7467 Compare September 12, 2022 09:02
@sergiud
Copy link
Contributor Author

sergiud commented Sep 12, 2022

Good point, thanks. I can confirm that this works on my end too. I've updated the PR.

@vitaut vitaut merged commit e2f6d76 into fmtlib:master Sep 12, 2022
@vitaut
Copy link
Contributor

vitaut commented Sep 12, 2022

Thank you!

@sergiud sergiud deleted the gcc-7.1-and-below-compile-errors branch September 12, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile errors with GCC 7.1 and below
3 participants
@sergiud @mwinterb @vitaut