Remove duplicate template parameter. #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Oct 14, 2022
include/fmt/chrono.h
Outdated
| @@ -2052,16 +2052,17 @@ struct formatter<std::chrono::duration<Rep, Period>, Char> { | |||
| } | |||
| }; | |||
|
|
|||
| template <typename Char, typename Duration> | |||
| struct formatter<std::chrono::time_point<std::chrono::system_clock, Duration>, | |||
| template <typename Rep, typename Period, typename Char> | |||
There was a problem hiding this comment.
Why change template parameters? I suggest keeping the old ones at least for consistency with utc formatter and change the format function instead.
There was a problem hiding this comment.
We need Rep and Period types for the condition on lines 2070-2071.
There was a problem hiding this comment.
Yeah but these are available as Duration::rep and Duration::period. I don't think we need them here.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
phprus
force-pushed
the
chrono-warning-1
branch
from
c5841d1
to
1d7b97a
Compare
vitaut
approved these changes
Oct 14, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #3140.