Fix build with MSVC C++20 modules #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using fmt with C++20 modules under MSVC, it can end up requiring certain things to have storage that would not otherwise have needed to. Since I didn't see anything that was already doing detection for `inline constexpr` variable support, I've just moved the entire thing into the only function where it's used.
vitaut
reviewed
Dec 29, 2022
include/fmt/core.h
Outdated
| @@ -395,9 +395,9 @@ FMT_CONSTEXPR auto to_unsigned(Int value) -> | |||
| return static_cast<typename std::make_unsigned<Int>::type>(value); | |||
| } | |||
|
|
|||
| FMT_MSC_WARNING(suppress : 4566) constexpr unsigned char section[] = "\u00A7"; | |||
| FMT_CONSTEXPR auto is_utf8() -> bool { | |||
There was a problem hiding this comment.
You need inline here because FMT_CONSTEXPR expands to nothing on compilers that don't support relaxed constexpr.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fmt with C++20 modules under MSVC, it can end up requiring certain things to have storage that would not otherwise have needed to. Since I didn't see anything that was already doing detection for
inline constexprvariable support, I've just moved the entire thing into the only function where it's used. I've also swapped the function fromconstexprtoFMT_CONSTEXPRsince it's no longer a simple C++11 constexpr function.