Support fill, align & width for time point #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnZhong
commented
Jan 4, 2023
| auto begin = ctx.begin(), end = ctx.end(); | ||
| if (begin == end || *begin == '}') return end; | ||
|
|
||
| begin = detail::parse_align(begin, end, specs); |
There was a problem hiding this comment.
Just realized that parse_align(begin, end, specs) is marked as deprecated, should we use parse_format_specs instead?
One thing that doesn't work with parse_format_specs is that an error is thrown on the line enter_state(state::align, align != align::none); since it does not recognize % and falls into default.
There was a problem hiding this comment.
It's OK to use parse_align here. It might be easier to clean up and undeprecate parse_align instead of adjusting parse_format_specs but I need to think about it more.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3237