Implement glibc ext for sec, min, and hour #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnZhong
force-pushed
the
glibc_ext
branch
3 times, most recently
from
b9f8bf1
to
0f10801
Compare
phprus
reviewed
Jan 13, 2023
vitaut
reviewed
Jan 22, 2023
| @@ -664,6 +664,30 @@ enum class numeric_system { | |||
| alternative | |||
| }; | |||
|
|
|||
| // Glibc extensions for formatting numeric values. | |||
| enum class pad_type { | |||
| unspecified, | |||
There was a problem hiding this comment.
Do we need unspecified? It looks like it's always handled as zero and can be removed.
There was a problem hiding this comment.
Based on the current codebase, yes.
Comment on lines
+672
to
+673
| // Pad a numeric result string with zeros even if the conversion specifier | ||
| // character uses space-padding by default. |
There was a problem hiding this comment.
Which conversion specifiers use space padding by default?
There was a problem hiding this comment.
For example, the command date "+%10a" prints Tue on Ubuntu 22.04.1.
If we were to implement the glibc extension for the optional width, we might need to consider this padding. Otherwise, we don't have space padding in the current codebase.
vitaut
reviewed
Feb 6, 2023
There was a problem hiding this comment.
@ShawnZhong, thanks for the PR. It looks good overall but I have some minor questions (inline).
|
This missed some things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2959