Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #3319. #3321

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Fix for issue #3319. #3321

merged 1 commit into from
Mar 5, 2023

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Feb 26, 2023

Fix for issue #3319.
Disable debug format because path is already escaped.

@phprus phprus marked this pull request as draft February 26, 2023 06:29
@phprus
Copy link
Contributor Author

phprus commented Feb 26, 2023 •
edited
Loading

Depends on #3322 and #3323

@phprus phprus force-pushed the issue-3319 branch 2 times, most recently from e074835 to 8123afe Compare March 4, 2023 16:50
@phprus
Copy link
Contributor Author

phprus commented Mar 4, 2023

@vitaut
Rebased and ready for review.

@phprus phprus marked this pull request as ready for review March 4, 2023 17:01
vitaut
vitaut requested changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good, just two minor comments inline.

test/std-test.cc Outdated Show resolved Hide resolved
test/std-test.cc Outdated Show resolved Hide resolved
@phprus
Path is not escaped twice in the debug mode
940fe41 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
Copy link
Contributor Author

phprus commented Mar 5, 2023

@vitaut
PR updated.

@vitaut vitaut merged commit 0502936 into fmtlib:master Mar 5, 2023
@vitaut
Copy link
Contributor

vitaut commented Mar 5, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phprus @vitaut