towards better module testing #3397
Conversation
DanielaE
force-pushed
the
feature/towards-better-module-testing
branch
from
053cb16
to
978d365
Compare
|
Now that module support is getting better, I think we should kill a separate module test and make normal tests compatible with modules. This will avoid duplication and improve coverage. |
|
I agree. All the tests for internal, non-exported entities need to be excluded from the test suites when the API is brought in through imports rather than includes. As far as I can see, this requires
For the time being I have this working only in the module testing branch of my fork of {fmt} that focuses on the API surface, the development of work arounds, and the deployment of CI. This builds on the existing, old test approach and the related infrastructure in CMakeTests.txt. |
|
We don't need to modularize all tests at once. Even modularizing core-test alone would be better than the current state. |
| # include "fmt/os.h" | ||
| #endif // FMG_MODULE_TEST | ||
|
|
||
| #include "fmt/os.h" |
There was a problem hiding this comment.
With all compilers having converged to the 'strong module ownership' model we no longer need to fold module fmt into the test machinery for module tests. The module has all its symbols attached to the module (e.g. void foo() becomes void foo@fmt()), and the test machinery can have the same definitions attached to the global module within the same program.
Therefore, the test-main library can be reused as with all other tests. And all stuff conditionally compiled by FMT_MODULE_TEST can kicked out again. Both Clang and MSVC are fine with it. Strong ownership rulez!
test/module-test.cc
Outdated
| TEST(module_test, std_types) { | ||
| EXPECT_EQ(R"("42")", fmt::format("{}", std::filesystem::path("42"))); | ||
| EXPECT_EQ(R"(optional("42"))", | ||
| fmt::format("{}", std::optional<std::string>("42"))); | ||
| EXPECT_EQ("none", fmt::format("{}", std::optional<std::string>())); | ||
| EXPECT_EQ("variant(42)", | ||
| fmt::format("{}", std::variant<int, std::string>(42))); | ||
| EXPECT_EQ("monostate", fmt::format("{}", std::monostate())); | ||
| EXPECT_EQ("system:0", fmt::format("{}", std::error_code())); | ||
| EXPECT_EQ("0", fmt::format("{}", std::thread::id())); | ||
| EXPECT_EQ("42", fmt::format("{}", std::runtime_error("42"))); | ||
| } |
There was a problem hiding this comment.
I think we should stop adding new test cases to module-test.
There was a problem hiding this comment.
I can drop this for your repo and keep it in mine. I want tests now.
* use the standard `test-main.cc` component instead of injected test infrastructure sources * undo now obsolete commit `00235d8a` from July 2021 * Clang cannot import user-defined literals as it seems -> disable test * Clang emits duplicate, non-mergeable copies of `detail::buffer`'s vtable, causing linker errors -> disable test
DanielaE
force-pushed
the
feature/towards-better-module-testing
branch
from
978d365
to
409ed46
Compare
|
Thank you! |
test-main.cccomponent instead of injected test infrastructure sources00235d8afrom July 2021