Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct Char to base format_as formatter #3457

Merged
merged 1 commit into from
May 24, 2023

Conversation

gix
Copy link
Contributor

@gix gix commented May 23, 2023

Returning a non-char string_view from format_as fails to compile since the base formatter always uses char.

@vitaut vitaut merged commit 171a020 into fmtlib:master May 24, 2023
@vitaut
Copy link
Contributor

vitaut commented May 24, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants