Only use typeid() in std.h when it is available #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/chromium/subspace/actions/runs/5127988704/ demonstrates this PR at work with RTTI disabled |
mwinterb
reviewed
May 31, 2023
danakj
force-pushed
the
master
branch
2 times, most recently
from
4441347
to
e27be85
Compare
vitaut
requested changes
May 31, 2023
On MSVC it is always available, otherwise it depends on whether RTTI is enabled.
The condition is constexpr, so the compiler warns if a runtime check is used as there's no need to generate code for it.
vitaut
approved these changes
May 31, 2023
|
Thank you! |
|
Thank you as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the std.h formatters to work when RTTI is disabed.
For issue #3464