Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std::copy usage. #3550

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Remove std::copy usage. #3550

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc57db
Remove std::copy usage.
Ozomahtli Jul 25, 2023
b249299
Use constexpr copy.
Ozomahtli Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2896,7 +2896,7 @@ class bigint {
auto size = other.bigits_.size();
bigits_.resize(size);
auto data = other.bigits_.data();
std::copy(data, data + size, bigits_.data());
std::uninitialized_copy(data, data + size, bigits_.data());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like uninitialized_copy is not constexpr. Let's replace it with

copy_str<bigit>(data, data + size, bigits_.data());

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

exp_ = other.exp_;
}

Expand Down
Loading