Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_string supports types with format_as #3555

Closed
wants to merge 1 commit into from
Closed

to_string supports types with format_as #3555

wants to merge 1 commit into from

Conversation

mjerabek
Copy link
Contributor

POC implementation of #3545. I'm not sure if this is the right/preferred way of implementing this, so I didn't test it very thorougly yet.

Closes #3545

vitaut
vitaut requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think it's better to apply format_as to the to_string overload where it is missing (possibly splitting it into two overloads) instead of changing write.

@phprus phprus mentioned this pull request Aug 7, 2023
Merged
@vitaut
Copy link
Contributor

vitaut commented Aug 7, 2023

Closing in favor of #3575 but thanks for your work!

@vitaut vitaut closed this Aug 7, 2023
@mjerabek
Copy link
Contributor Author

mjerabek commented Aug 7, 2023

Right, completely forgot about it 🤦. Nice to see it done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_string() doesn't work with custom format_as()?
2 participants
@mjerabek @vitaut