Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atomic_flag formatting #3594

Merged
merged 6 commits into from
Aug 25, 2023
Merged

atomic_flag formatting #3594

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08663e4
Implement `atomic_flag` formatter
AlexGuteniev Aug 14, 2023
4499c61
Test
AlexGuteniev Aug 14, 2023
f45cfad
Update std-test.cc
AlexGuteniev Aug 14, 2023
461637e
true
AlexGuteniev Aug 14, 2023
1b22c50
don't check the feature version in product code
AlexGuteniev Aug 25, 2023
5803462
don't check the feature version in test code
AlexGuteniev Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions include/fmt/std.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,5 +448,19 @@ struct formatter<std::atomic<T>, Char,
}
};

#if defined(__cpp_lib_atomic_flag_test) && __cpp_lib_atomic_flag_test >= 201907L
AlexGuteniev marked this conversation as resolved.
Show resolved Hide resolved
FMT_EXPORT
template <typename Char>
struct formatter<std::atomic_flag, Char,
enable_if_t<is_formattable<bool, Char>::value>>
AlexGuteniev marked this conversation as resolved.
Show resolved Hide resolved
: formatter<bool, Char> {
template <typename FormatContext>
auto format(const std::atomic_flag& v, FormatContext& ctx) const
-> decltype(ctx.out()) {
return formatter<bool, Char>::format(v.test(), ctx);
}
};
#endif // defined(__cpp_lib_atomic_flag_test) && __cpp_lib_atomic_flag_test >= 201907L

FMT_END_NAMESPACE
#endif // FMT_STD_H_
11 changes: 11 additions & 0 deletions test/std-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,14 @@ TEST(std_test, format_atomic) {
const std::atomic<bool> cb(true);
EXPECT_EQ(fmt::format("{}", cb), "true");
}

#if defined(__cpp_lib_atomic_flag_test) && __cpp_lib_atomic_flag_test >= 201907L
TEST(std_test, format_atomic_flag) {
std::atomic_flag f = ATOMIC_FLAG_INIT;
(void) f.test_and_set();
EXPECT_EQ(fmt::format("{}", f), "true");

const std::atomic_flag cf = ATOMIC_FLAG_INIT;
EXPECT_EQ(fmt::format("{}", cf), "false");
}
#endif // defined(__cpp_lib_atomic_flag_test) && __cpp_lib_atomic_flag_test >= 201907L