-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Compilation Error When Using FMT_MODULE #3597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please rebase it and resolve conflicts.
include/fmt/core.h
Outdated
@@ -1662,7 +1662,7 @@ template <typename Context> class basic_format_arg { | |||
\endrst | |||
*/ | |||
// DEPRECATED! | |||
FMT_EXPORT | |||
//FMT_EXPORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had commented it out when trying to diagnose the issue which was that there was an FMT_EXPORT between a block of FMT_BEGIN_EXPORT and FMT_END_EXPORT. Forgot to take it out.
Now that it I managed to get it working I will take it out, rebase and resolve conflicts as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, please remove this redundant FMT_EXPORT
instead of commenting out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I thought I had removed it in previous commit.
- When compiling with FMT_MODULE, an error was being generated due to use of FMT_EXPORT on a declaration within FMT_BEGIN_EXPORT and FMT_END_EXPORT on `include/core.h` - On `include/format.h` had to exclude the function vformat_to by ending the export block just before it and beginning a new one after it.
607621e
to
a1659de
Compare
Merged, thanks. |
No description provided.