Fix for Compilation Error When Using FMT_MODULE #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Aug 18, 2023
include/fmt/core.h
Outdated
| @@ -1662,7 +1662,7 @@ template <typename Context> class basic_format_arg { | |||
| \endrst | |||
| */ | |||
| // DEPRECATED! | |||
| FMT_EXPORT | |||
| //FMT_EXPORT | |||
There was a problem hiding this comment.
I had commented it out when trying to diagnose the issue which was that there was an FMT_EXPORT between a block of FMT_BEGIN_EXPORT and FMT_END_EXPORT. Forgot to take it out.
Now that it I managed to get it working I will take it out, rebase and resolve conflicts as requested.
There was a problem hiding this comment.
Yeah, please remove this redundant FMT_EXPORT instead of commenting out.
There was a problem hiding this comment.
My apologies, I thought I had removed it in previous commit.
- When compiling with FMT_MODULE, an error was being generated due to use of FMT_EXPORT on a declaration within FMT_BEGIN_EXPORT and FMT_END_EXPORT on `include/core.h` - On `include/format.h` had to exclude the function vformat_to by ending the export block just before it and beginning a new one after it.
MathewBensonCode
force-pushed
the
master
branch
from
607621e
to
a1659de
Compare
vitaut
approved these changes
Aug 20, 2023
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.