Remove type cast as mxe(mingw32) compiler complains about useless-cast #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when FMT_PEDANTIC && FMT_WERROR options are enabled """ error: useless cast to type 'class fmt::v10::basic_format_args<fmt::v10::basic_format_context<fmt::v10::appender, char> >' [-Werror=useless-cast] 1449 | basic_format_args<buffer_context<char>>(args)); """
vitaut
requested changes
Sep 5, 2023
include/fmt/format-inl.h
Outdated
| @@ -1446,7 +1446,7 @@ FMT_FUNC bool write_console(std::FILE* f, string_view text) { | |||
| FMT_FUNC void vprint_mojibake(std::FILE* f, string_view fmt, format_args args) { | |||
| auto buffer = memory_buffer(); | |||
| detail::vformat_to(buffer, fmt, | |||
| basic_format_args<buffer_context<char>>(args)); | |||
| args); | |||
There was a problem hiding this comment.
args should go on the previous line now that it fits there.
There was a problem hiding this comment.
Hi Vitaut,
Changes done as per your suggestion.
|
Hi Vitaut, Changes done as per your suggestion. |
vitaut
approved these changes
Sep 5, 2023
|
Thanks |
ckerr
pushed a commit
to transmission/fmt
that referenced
this pull request
Nov 7, 2023
fmtlib#3624) Remove type cast as mxe(mingw32) compiler complains about useless-cast when FMT_PEDANTIC && FMT_WERROR options are enabled """ error: useless cast to type 'class fmt::v10::basic_format_args<fmt::v10::basic_format_context<fmt::v10::appender, char> >' [-Werror=useless-cast] 1449 | basic_format_args<buffer_context<char>>(args)); """
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove type cast as mxe(mingw32) compiler complains about useless-cast
when FMT_PEDANTIC && FMT_WERROR options are enabled """
error: useless cast to type 'class fmt::v10::basic_format_args<fmt::v10::basic_format_context<fmt::v10::appender, char> >' [-Werror=useless-cast]
1449 | basic_format_args<buffer_context>(args));
"""