FMT_USE_CPP11 option pollutes build flags with '-std=c++11' #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default FMT_USE_CPP11 only when MASTER_PROJECT is ON.
|
Thanks for the PR! I agree that the library shouldn't add |
vitaut
added a commit
that referenced
this pull request
Aug 5, 2016
|
Does 12a6027 work for you? |
|
Closing this in favor of 12a6027, but comments are welcome. |
foonathan
pushed a commit
that referenced
this pull request
Oct 23, 2016
(cherry picked from commit 12a6027)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When included (with add_subdirectory),
FMT_USE_CPP11option pollutes build flags with-std=c++11. If master project hasset(CMAKE_CXX_STANDARD 14), then compilation flags become-std=c++11 -std=gnu++14.Enable
FMT_USE_CPP11by default only whenMASTER_PROJECTisON, otherwise inherit from master project.