Fix error C2668 on Windows with option /std:c++latest #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est.cc When build fmt with MSVC under option /std:c++latest, it failed due to `error 2668: 'std::format_to': ambiguous call to overloaded function`, so add namespace to qualify the call to format_to to avoid this issue.
vitaut
requested changes
Oct 14, 2023
Remove unnecessary comments.
vitaut
approved these changes
Oct 16, 2023
|
Thanks |
ckerr
pushed a commit
to transmission/fmt
that referenced
this pull request
Nov 7, 2023
* Namespace-qualify to avoid ambiguity with std::format_to for format-test.cc When build fmt with MSVC under option /std:c++latest, it failed due to `error 2668: 'std::format_to': ambiguous call to overloaded function`, so add namespace to qualify the call to format_to to avoid this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build fmt with MSVC under option /std:c++latest, it failed due to
error 2668: 'std::format_to': ambiguous call to overloaded function, so add namespace to qualify the call to format_to to avoid this issue. Could you please review and approval it? Thanks.It is the same issue as #3377.