Fix include xlocale #3699
Closed
Fix include xlocale #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Nov 2, 2023
include/fmt/os.h
Outdated
| @@ -14,7 +14,9 @@ | |||
| #include <system_error> // std::system_error | |||
|
|
|||
| #if defined __APPLE__ || defined(__FreeBSD__) | |||
| # include <xlocale.h> // for LC_NUMERIC_MASK on OS X | |||
| # if (__cplusplus < 201703L) || __has_include(<xlocale.h>) | |||
There was a problem hiding this comment.
Please use FMT_HAS_INCLUDE(<xlocale.h>) instead of these checks.
There was a problem hiding this comment.
@vitaut Hi, I changed the code to use FMT_HAS_INCLUDE and rebased on origin's master.
hotwatermorning
force-pushed
the
fix-include-xlocale
branch
from
1ca3f28
to
b345027
Compare
vitaut
approved these changes
Nov 2, 2023
|
Merged with a minor tweak, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use fmtlib's fmt on some console game development environment, but os.h doesn't compile because of missing of xlocale.h.
Therefore I added
__has_include()check before including xlocale.h.Thanks.