Set PDB path for Visual Studio #3702
Conversation
CMakeLists.txt
Outdated
| DEBUG_POSTFIX "${FMT_DEBUG_POSTFIX}" | ||
| COMPILE_PDB_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}" | ||
| COMPILE_PDB_NAME "fmt" | ||
| COMPILE_PDB_NAME_DEBUG "fmt${FMT_DEBUG_POSTFIX}") |
There was a problem hiding this comment.
Please add a short comment clarifying that these are for MSVC 2017 only. We'll remove this workaround in the future once the compiler version is no longer supported.
There was a problem hiding this comment.
Happy to do that, but I'm not sure this should be looked at as a temporary workaround. Not having it leaves you at the mercy of the defaults and I'm worried that in some future VS version the defaults could change again to who knows what.
Would you still like me to describe it as a temporary workaround, or as something that simply has to be set for Visual Studio?
There was a problem hiding this comment.
Would you still like me to describe it as a temporary workaround, or as something that simply has to be set for Visual Studio?
Yes, please. We don't need to guard against theoretical future MSVC regressions.
Ensure the PDB files are output into the same directory and with the same name as the static library when using Visual Studio. Resolves fmtlib#3701.
Ensure the PDB files are output into the same directory and with the same name as the static library when using Visual Studio. Resolves fmtlib#3701.
Ensure the PDB files are output into the same directory and with the same name as the static library when using Visual Studio.
Resolves #3701.