fix: support optional<T> with format_as(T) (#3712)
#3713
Conversation
There was a problem hiding this comment.
Thanks for the PR. Overall looks good but could you add a test case to https://github.com/fmtlib/fmt/blob/master/test/std-test.cc?
cptFracassa
force-pushed
the
fmt-format_as-optional
branch
from
7690be8
to
a476850
Compare
I have done so now 😃 |
test/std-test.cc
Outdated
| one, | ||
| two, | ||
| }; | ||
| auto format_as(my_number number) { |
There was a problem hiding this comment.
Here and below a return type is needed.
There was a problem hiding this comment.
Here and below a return type is needed.
Added now. I am spoiled by working with C++20...
| @@ -90,6 +90,34 @@ TEST(std_test, optional) { | |||
| #endif | |||
| } | |||
|
|
|||
| namespace my_nso { | |||
There was a problem hiding this comment.
What does "nso" stand for?
I was trying to follow the naming scheme with short namespaces below, my_ns1 & my_ns2, and added an o for optional, since my_ns3 before the two others didn't make sense. But I'll change to whatever you prefer.
Formatting a std::optional<T> where T had a custom format_as(T) function failed to compile with clang, due to set_debug_format being hidden by private inheritance. This fix makes the function available through a using clause.
cptFracassa
force-pushed
the
fmt-format_as-optional
branch
from
a476850
to
75050ae
Compare
Formatting a std::optional<T> where T had a custom format_as(T) function failed to compile with clang, due to set_debug_format being hidden by private inheritance. This fix makes the function available through a using clause.
Formatting a
std::optional<T>where T had a customformat_as(T)function failed to compile with clang, due toset_debug_formatbeing hidden by private inheritance. This fix makes the function available through a using clause.This fixes #3712