Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native and generic representation for filesystem::path format spec #3729

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

js324
Copy link
Contributor

@js324 js324 commented Nov 27, 2023

Hi,
First time contributor here. This fixes #3715 by adding a "type" format spec to the formatter of std::filesystem::path to allow either native or generic format of the path. Added tests as well.
Please let me know if there's anything to fix. Thanks

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Two nits inline, otherwise LGTM.

include/fmt/std.h Outdated Show resolved Hide resolved
include/fmt/std.h Outdated Show resolved Hide resolved
@js324
Copy link
Contributor Author

js324 commented Nov 29, 2023

Done, thanks!

@js324 js324 requested a review from vitaut November 29, 2023 03:11
@vitaut vitaut merged commit b87ea22 into fmtlib:master Nov 29, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support both generic and native format of std::filesystem::path
2 participants