Added formatter for std::source_location #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix642
force-pushed
the
std_source_location_formatter
branch
from
d447537
to
45ca5e9
Compare
|
Pipeline seems to fail on windows, I'll have a look and mark the PR as ready for review when the pipeline will be ok. |
felix642
force-pushed
the
std_source_location_formatter
branch
from
ce50030
to
54eaa8c
Compare
vitaut
requested changes
Nov 30, 2023
Removed template parameter
vitaut
requested changes
Nov 30, 2023
vitaut
approved these changes
Nov 30, 2023
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom formatter for std::source_location to support this type of code :
fmt::print("{}\n", std::source_location::current());The format was taken from the following discussion : #3012 (comment)
Let me know if there is a better format that could be implemented.