Implement %j specifier for std::chrono::duration
#3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelfx
changed the title
%j specifier for std::chrono::duration%j specifier for std::chrono::duration
vitaut
requested changes
Dec 2, 2023
include/fmt/chrono.h
Outdated
Comment on lines
1893
to
1894
| if (handle_nan_inf()) return; | ||
| return write(days(), 0); |
There was a problem hiding this comment.
This can be simplified to
if (!handle_nan_inf()) write(days(), 0);There was a problem hiding this comment.
I did it this way to keep the code stylistically similar to the rest of the handlers which all have the same guard statement in the beginning of the function body. I can change it if you insist though :-)
There was a problem hiding this comment.
OK, but at the very least there shouldn't be return before write because this is a void function.
There was a problem hiding this comment.
Ah, yes you are right of course, not sure where did I get this idea from.
vitaut
reviewed
Dec 2, 2023
intelfx
force-pushed
the
work/duration-on-day-of-year
branch
2 times, most recently
from
4b4f224
to
26ae9fb
Compare
vitaut
reviewed
Dec 2, 2023
This adds support for `%j` presentation type for duration types: > "If the type being formatted is a specialization of duration, the decimal number of days without padding." Fixes fmtlib#3643.
intelfx
force-pushed
the
work/duration-on-day-of-year
branch
from
26ae9fb
to
78a6117
Compare
vitaut
approved these changes
Dec 2, 2023
|
Merged, thanks! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
This adds support for `%j` presentation type for duration types: > "If the type being formatted is a specialization of duration, the decimal number of days without padding." Fixes fmtlib#3643.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
%jpresentation type for duration types:Fixes #3643.
I assume it isn't needed to handle padding or alternative numeric systems here as neither is mentioned in the specification, thus the implementation is basically one line. (Please correct me if I'm wrong.)