Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated #3748

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Dec 9, 2023

Fix error (clang-17):

In file included from /home/runner/work/fmt/fmt/test/printf-test.cc:14:
/home/runner/work/fmt/fmt/include/fmt/xchar.h:73:47: error: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   73 | constexpr detail::udl_arg<wchar_t> operator"" _a(const wchar_t* s, size_t) {
      |                                    ~~~~~~~~~~~^~
      |                                    operator""_a

…or declaration is deprecated

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut changed the title Fix error: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated Fix warning: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated Dec 9, 2023
@vitaut vitaut merged commit 6392dba into fmtlib:master Dec 9, 2023
40 checks passed
@vitaut
Copy link
Contributor

vitaut commented Dec 9, 2023

This is a warning promoted to an error with -Werror but otherwise LGTM. Thanks.

happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
…ator declaration is deprecated (fmtlib#3748)

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants