Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMT_OS definition #3783

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix FMT_OS definition #3783

merged 1 commit into from
Jan 2, 2024

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Jan 2, 2024

If cmake option FMT_OS is OFF then define FMT_OS=0.
If cmake option FMT_OS is ON then FMT_OS is not defined by cmake and defined in fmt.cc:

fmt/src/fmt.cc

Lines 86 to 88 in 6c3b2d4

#ifndef FMT_OS
# define FMT_OS 1
#endif

issue: #3777

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut merged commit 7fd1802 into fmtlib:master Jan 2, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jan 2, 2024

Good catch, thanks!

happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants