Workaround for gcc 6 #3810
Merged
Workaround for gcc 6 #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
sergiud
reviewed
Jan 15, 2024
| @@ -179,7 +179,8 @@ For example:: | |||
| struct fmt::formatter<point> : nested_formatter<double> { | |||
| auto format(point p, format_context& ctx) const { | |||
| return write_padded(ctx, [=](auto out) { | |||
| return format_to(out, "({}, {})", nested(p.x), nested(p.y)); | |||
| return format_to(out, "({}, {})", this->nested(p.x), | |||
There was a problem hiding this comment.
Does it make sense to mention that specifying this here is only necessary when using GCC <7?
There was a problem hiding this comment.
I don't think this makes sense.
|
Thanks for the fix! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: #3809
Demo: https://godbolt.org/z/v77xfGT4f