Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really fix MSVC warning about <bit> only being available in C++20. #3832

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Really fix MSVC warning about <bit> only being available in C++20. #3832

merged 2 commits into from
Jan 30, 2024

Conversation

res2k
Copy link
Contributor

@res2k res2k commented Jan 30, 2024

The warning states "The contents of are available only with C++20 or later.", but the check was for C++17 and later.

Follow-up to #3807.

@res2k
Really fix MSVC warning about <bit> only being available in C++20.
388d229 
The warning states "The contents of <bit> are available only with C++20 or later.",
but the check was for C++17 and later.
@phprus
Copy link
Contributor

phprus commented Jan 30, 2024

Oh! You're right!

I made a mistake and used the >= check instead of > in PR #3807.

phprus
phprus reviewed Jan 30, 2024
View reviewed changes
include/fmt/format.h Outdated Show resolved Hide resolved
vitaut
vitaut requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. In general looks good but please change to > as suggested by @phprus.

@vitaut vitaut merged commit 71a4a8d into fmtlib:master Jan 30, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jan 30, 2024

Merged, thanks.

@res2k res2k deleted the really-fix-msvc-bit-warning branch February 1, 2024 16:12
happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
@res2k @happymonkey1
Really fix MSVC warning about <bit> only being available in C++20. (f…
4c30733 
…mtlib#3832)

* Really fix MSVC warning about <bit> only being available in C++20.

The warning states "The contents of <bit> are available only with C++20 or later.",
but the check was for C++17 and later.

* Change <bit> inclusion check per fmtlib#3832 (comment)
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phprus phprus phprus left review comments

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@res2k @phprus @vitaut