added formatter for std::expected #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phprus
reviewed
Jan 31, 2024
|
Merged, thanks! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
CJCombrink
reviewed
Jul 1, 2024
|
|
||
| if (value.has_value()) { | ||
| out = detail::write<Char>(out, "expected("); | ||
| out = detail::write_escaped_alternative<Char>(out, value.value()); |
There was a problem hiding this comment.
Wouldn't *value be a better call here?
Given that it was confirmed that value has_value() there should be no need for the 'checked retrieval' of the value?
see std::expected<T,E>::operator*
out = detail::write_escaped_alternative<Char>(out, *value);
(edit) I know this is after the fact, I am just working through the release notes
There was a problem hiding this comment.
Sure, a PR to change this to use dereference would be welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation of a 'std::expected' formatter.
Open for discussions :)
By submitting this pull request, you agree to license your contribution(s)
under the terms outlined in LICENSE.rst and represent that you have the right
to do so.