Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.h c++23 build fix #3856

Merged
merged 1 commit into from
Feb 19, 2024
Merged

std.h c++23 build fix #3856

merged 1 commit into from
Feb 19, 2024

Conversation

prlw1
Copy link
Contributor

@prlw1 prlw1 commented Feb 17, 2024

Add ::value to is_formattable<...> as per suggestion by @vitaut in #3854

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Mostly looks good but please apply clang-format.

Add ::value to is_formattable<...> as per suggestion by @vitaut in
fmtlib#3854
@vitaut vitaut merged commit 0166f45 into fmtlib:master Feb 19, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Feb 19, 2024

Thank you for the fix!

happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
Add ::value to is_formattable<...> as per suggestion by @vitaut in
fmtlib#3854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants