Implemented fmt::day, fmt::month, fmt::year and related unit tests #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented fmt::day, fmt::month, fmt::year revert a test file that got committed accidentally remove unnecessary using statements in chrono-test Fixed a compiler error in CPP20 take uint instead unsigned char for fmt::day and fmt::month as in std::chrono fix weekday::c_encoding return value fixed an issue that std uses a range of 1-12 for month, but fmt uses 0-11
|
Okay, I give up interactive rebase, it does not erase the commits here. |
vitaut
requested changes
Mar 26, 2024
vitaut
approved these changes
Mar 28, 2024
|
Merged, thanks! |
|
looks like it did not build for clang, investigating. Should I back it out in the mean time? @vitaut |
|
@phprus already fixed it (thanks!) |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3758