Fix format_to + FMT_STRING for wide character type #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is the optimal fix, though :) |
vitaut
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks for the PR. I think it's better to keep detail::to_string_view and instead add a format_to overload that takes wformat_string similar to this one:
Line 140 in aa52eb7
Added overload that takes a wformat_string. Fixes issue fmtlib#3925.
vitaut
reviewed
Apr 16, 2024
vitaut
approved these changes
Apr 17, 2024
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3925