Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from MSVC #3933

Closed
wants to merge 3 commits into from
Closed

Fix warnings from MSVC #3933

wants to merge 3 commits into from

Conversation

jimmy-park
Copy link
Contributor

Following warnings are detected by MSVC Code Analysis.

  • C26439 : This kind of function may not throw. Declare it noexcept.
  • C26495 : Variable is uninitialized. Always initialize a member variable (type.6).
  • C26498 : The function is constexpr, mark variable constexpr if compile-time evaluation is desired (con.5).

@vitaut
Copy link
Contributor

vitaut commented Apr 19, 2024

Thanks for the PR. The move ctor noexcept change makes sense: merged in f4b256c. The other analysis warnings are mostly noise and can be ignored.

@vitaut vitaut closed this Apr 19, 2024
@jimmy-park jimmy-park deleted the fix-msvc-warnings branch April 19, 2024 16:21
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmy-park @vitaut