Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe time formatting #396

Closed
wants to merge 1 commit into from
Closed

Thread-safe time formatting #396

wants to merge 1 commit into from

Conversation

codicodi
Copy link
Contributor

@codicodi codicodi commented Oct 9, 2016

This adds thread-safe (at least on platforms that provide necessary extensions) replacement functions for std::localtime and std::gmtime. Alternatively they could be placed in a new source file time.cc, but time.h seems so empty right now...

This adds thread-safe (at least on platforms that provide necessary extensions) replacement functions for std::localtime and std::gmtime. Alternatively they could be placed in a new source file time.cc, but time.h seems so empty right now...
@vitaut
Copy link
Contributor

vitaut commented Oct 10, 2016

Awesome, thanks! Could you also add unit tests for this to posix-mock-test and/or time-test?

@vitaut
Copy link
Contributor

vitaut commented Oct 17, 2016

Merged with minor coding style changes for consistency and unit tests in 1e018e6.

@vitaut vitaut closed this Oct 17, 2016
@vitaut
Copy link
Contributor

vitaut commented Oct 17, 2016

Thanks again.

@codicodi codicodi deleted the patch-1 branch November 1, 2016 21:23
vitaut pushed a commit that referenced this pull request Jan 21, 2018
@vitaut
Copy link
Contributor

vitaut commented Aug 18, 2019

@codicodi, could you please review the updated CONTIBUTING document, particularly the part about licensing, and let me know if you agree with it being applied to your contributions to {fmt}? The library is likely to be relicensed (#1073) so I'm collecting approval from all earlier contributors. Thanks!

@codicodi
Copy link
Contributor Author

@vitaut, I see the license change happened already and just wanted to let you know I'm fine with it.
Sorry for delay.

@vitaut
Copy link
Contributor

vitaut commented Nov 29, 2019

Thanks for the confirmation, @codicodi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants