Remove unnecessary "fmt/" prefix inside fmt directory #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream
…tional include_directories() in each project.
|
The |
vitaut
added a commit
that referenced
this pull request
Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest removing "fmt/" prefix in *.h, *.cc files inside fmt directory. Consider someone using fmt library as a git submodule or third-party library and has format.h helper file with direct referencing:
include "../../modules/fmt/fmt/format.h"
include "../../modules/fmt/fmt/ostream.h"
Nevertheless I put explicit relative path to format.h and ostream.h I need to add include_directories("modules/fmt") anywhere I use my format.h helper, because ostream.h contins the following inside:
include "fmt/format.h"
and I believe it could be easily replaced without any side effects with
include "format.h"