Use native c++ module support from CMake #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix some clang compilation issues when using c++ modules
…RATOR and chrono.h
vitaut
requested changes
Jun 5, 2024
| @@ -4285,6 +4288,8 @@ extern template FMT_API auto decimal_point_impl(locale_ref) -> char; | |||
| extern template FMT_API auto decimal_point_impl(locale_ref) -> wchar_t; | |||
| #endif // FMT_HEADER_ONLY | |||
|
|
|||
| FMT_END_EXPORT | |||
There was a problem hiding this comment.
Why exclude native_formatter<T, Char, TYPE>::format from export? If you get an error please post it here for future reference.
There was a problem hiding this comment.
The error is:
In file included from fmt/src/fmt.cc:99:
In file included from fmt/include/fmt/args.h:17:
In file included from fmt/include/fmt/args.h:17:
fmt/include/fmt/format.h:4293:64: error: cannot export 'format' as it is not at namespace scope
4293 | FMT_CONSTEXPR FMT_INLINE auto native_formatter<T, Char, TYPE>::format(
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
fmt/include/fmt/format.h:4295:7: error: invalid use of non-static data member 'specs_'
fmt/include/fmt/format.h:4295:7: error: 'specs_' is a private member of 'native_formatter<T, Char, TYPE>'
fmt/include/fmt/base.h:2796:30: note: declared private here
4295 | if (specs_.width_ref.kind == arg_id_kind::none &&
2796 | dynamic_format_specs<Char> specs_;
| ^~~~~~
| ^
There was a problem hiding this comment.
Maybe useful: llvm/llvm-project#61890
There was a problem hiding this comment.
So if you wanna export native_formatter<T, Char, TYPE>::format you should export native_formatter<T, Char, TYPE> instead. I tried and it compiled. If you think it okay I can commit it.
vitaut
approved these changes
Jun 6, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix some clang compilation issues when using c++ modules
close #3990