Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard more system headers by FMT_MODULE #4006

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Guard more system headers by FMT_MODULE #4006

merged 2 commits into from
Jun 14, 2024

Conversation

yujincheng08
Copy link
Contributor

vitaut
vitaut requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we should use a single macro to make this cleaner when possible, e.g. FMT_MODULE (and set it if FMT_IMPORT_STD is defined).

@yujincheng08 yujincheng08 requested a review from vitaut June 13, 2024 13:58
@yujincheng08 yujincheng08 force-pushed the patch-3 branch 2 times, most recently from 485aef2 to c6f4208 Compare June 13, 2024 14:05
vitaut
vitaut requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good, just minor comments inline.

include/fmt/base.h Outdated Show resolved Hide resolved
include/fmt/format-inl.h Outdated Show resolved Hide resolved
include/fmt/format-inl.h Outdated Show resolved Hide resolved
@yujincheng08 yujincheng08 requested a review from vitaut June 14, 2024 03:18
@vitaut vitaut merged commit 8687315 into fmtlib:master Jun 14, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jun 14, 2024

Merged, thanks!

@yujincheng08 yujincheng08 deleted the patch-3 branch June 14, 2024 17:56
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yujincheng08 @vitaut