Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress a bogus warning in MSVC #4023

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Suppress a bogus warning in MSVC #4023

merged 1 commit into from
Jun 19, 2024

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Jun 17, 2024

<source_location> and <ranges> is C++20 heades (FMT_CPLUSPLUS > 201703L), not C++17 (FMT_CPLUSPLUS >= 201703L).

Warnings:

The contents of <ranges> are available only with C++20 or later.
The contents of <source_location> are available only with C++20 consteval support.

vitaut
vitaut reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

include/fmt/std.h Show resolved Hide resolved
@phprus
Suppress a bogus warning in MSVC
3d879c8 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut merged commit 514b695 into fmtlib:master Jun 19, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jun 19, 2024

Merged, thanks!

This was referenced Jul 1, 2024
Merged
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Closed
This was referenced Jul 1, 2024
Merged
Open
@renovate renovate bot mentioned this pull request Aug 22, 2024
Merged
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phprus @vitaut