Defines are still needed for FMT_MODULE as well #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jun 19, 2024
src/os.cc
Outdated
Comment on lines
41
to
42
| #if FMT_USE_FCNTL | ||
| # ifdef _WIN32 |
There was a problem hiding this comment.
We can merge these two now to reduce nesting:
#if FMT_USE_FCNTL && defined(_WIN32)
There was a problem hiding this comment.
Changed to #if defined(FMT_USE_FCNTL) && defined(_WIN32) (see below)
src/os.cc
Outdated
Comment on lines
41
to
42
| #if FMT_USE_FCNTL | ||
| # ifdef _WIN32 |
There was a problem hiding this comment.
Suggested change
| #if FMT_USE_FCNTL | |
| # ifdef _WIN32 | |
| #if defined(FMT_USE_FCNTL) && defined(_WIN32) |
There was a problem hiding this comment.
Correct it would be needed for FMT_USE_FCNTL == 0 and FMT_USE_FCNTL == 1 due to
constexpr mode_t default_open_mode =
S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
There was a problem hiding this comment.
It looks redundant now, let's just remove the FMT_USE_FCNTL check here.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative is duplicating these in fmt.cc.