Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve std::complex formatter #4050

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Improve std::complex formatter #4050

merged 1 commit into from
Jul 5, 2024

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Jul 3, 2024

Based on ideas: #4034

Implemented:

  • dynamic width
  • dynamic precision
  • sign, nan and inf handling

@phprus phprus marked this pull request as draft July 3, 2024 19:20
@phprus phprus force-pushed the complex-3 branch 3 times, most recently from 35c287a to be1ba09 Compare July 3, 2024 19:37
@phprus phprus marked this pull request as ready for review July 3, 2024 19:47
@phprus
Copy link
Contributor Author

phprus commented Jul 3, 2024

@vitaut
please, review this PR.

@phprus phprus marked this pull request as draft July 4, 2024 05:02
@phprus
Improve std::complex formatter
30e3c7e 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus phprus marked this pull request as ready for review July 4, 2024 12:22
vitaut
vitaut approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. All looks good but I'll merge it a bit later not to interfere with the upcoming patch release.

@phprus
Copy link
Contributor Author

phprus commented Jul 4, 2024

Current output (2+-2.2i) for complex<double>(2, -2.2) is a formatting error as I think.
Or is fix for this bug is not suitable to patch release?

@vitaut vitaut merged commit a962597 into fmtlib:master Jul 5, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jul 5, 2024

I missed the fix part. Makes sense to include in the patch release then.

@BrewTestBot BrewTestBot mentioned this pull request Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phprus @vitaut