Make support/python/mkdocstrings_handlers/cxx/__init__.py PEP 8 compliant (1 of 2)

[rturrado]

• Make file PEP 8 compliant:
  • Add missing members to Definition class.
  • convert_type can return str | None.
  • et is imported as ElementTree.
  • doxyxml2html can receive either a List[ElementTree.Element] or an ElementTree.Element.
  • type variable is renamed to type_ (and type_text) to avoid conflicts with built-in type.
  • templateparamlist is renamed to template_param_list.
  • Classes and global functions are separated by 2 blank lines.
  • Continuation lines are fixed.
  • Triple single quotes are replaced by triple double quotes.
  • Unused parameters are preceded by an underscore.
• Add a link to fmt's full license at the top of the file.

[vitaut]

Thanks for the PR. Are you talking about PEP 8 and could you split indent/whitespace change into a separate commit/PR to make the more important changes easier to see in the diff?

[rturrado]

Thanks for the PR. Are you talking about PEP 8

Yes! To be honest, I am just follow the recommendations (yellow flags) from CLion.

and could you split indent/whitespace change into a separate commit/PR to make the more important changes easier to see in the diff?

Sure, I'll do split it in 2.

[vitaut]

There is one error:

  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/runner/work/fmt/fmt/support/python/mkdocstrings_handlers/cxx/__init__.py", line 53, in <module>
    def doxyxml2html(nodes: List[ElementTree.Element] | ElementTree.Element):
TypeError: unsupported operand type(s) for |: '_GenericAlias' and 'type'

[rturrado]

There is one error:

  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/runner/work/fmt/fmt/support/python/mkdocstrings_handlers/cxx/__init__.py", line 53, in <module>
    def doxyxml2html(nodes: List[ElementTree.Element] | ElementTree.Element):
TypeError: unsupported operand type(s) for |: '_GenericAlias' and 'type'

Ooops, Python 3.8 doesn't like that | operator.

[vitaut]

Looks like this introduces infinite recursion: https://github.com/fmtlib/fmt/actions/runs/10303709064/job/28524343469?pr=4110

[vitaut]

Should probably be list(n) instead of [n] because what we need is a list of chile elements.

[rturrado]

Should probably be list(n) instead of [n] because what we need is a list of chile elements.

Oh my! I had introduced the from __future__ import annotations so that I could use the operator | (I tested this in a python:3.8 docker), but then I also pushed this change (something I was trying on my machine). Sorry about that! I hope it works now.

[vitaut]

Merged, thanks!

[rturrado]

Merged, thanks!

Yey, thanks to you!