Make support/python/mkdocstrings_handlers/cxx/__init__.py PEP 8 compliant (2 of 2)
#4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturrado
changed the title
support/python/mkdocstrings_handlers/cxx/__init__.py PEP 8 compliant (2nd part)support/python/mkdocstrings_handlers/cxx/__init__.py PEP 8 compliant (2 of 2)
…communicate's input.
vitaut
reviewed
Aug 10, 2024
| @@ -5,336 +5,336 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Is this needed? I got an impression from the discussion on the previous PR that it was added but not used.
There was a problem hiding this comment.
Good spot:
- Indeed, I had initially added this import because it allowed us to use the operator
|(e.g.,List[ElementTree.Element] | ElementTree.Element. - But then we change the code so that we were not using operator
|. - However, I hadn't removed it because, if I did it, I was getting a compilation error.
- I've fixed now that compilation error, by using
-> List[Definition]instead of-> list[Definition]atconvert_params.
This requires changing a 'list[]' into a 'List[]'. We had previously added this import because the code was making use of operator '|'. But that is no longer true, so the import shouldn't be needed.
|
Merged, thanks for cleaning this up! |
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change indents to 4 spaces.
Run isort.