Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export the -std=c++11 flag from the fmt target #445

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Don't export the -std=c++11 flag from the fmt target #445

merged 1 commit into from
Dec 30, 2016

Conversation

EricWF
Copy link
Contributor

@EricWF EricWF commented Dec 29, 2016

Currently the fmt CMake target exports -std=c++11 as part of its interface; Meaning any project that links to fmt has the -std=c++11 added to its compilation. However this will override the -std=<ver> flag provided by that project. This breaks projects that use C++14 or C++1z. In general I think it's bad style for projects to force a specific dialect, or any compile flags, upon its users.

This patch fixes the issue by making -std=c++11 a private flag of fmt. This prevent it from infecting downstream users.

@vitaut vitaut merged commit b9aaa50 into fmtlib:master Dec 30, 2016
@vitaut
Copy link
Contributor

vitaut commented Dec 30, 2016

Good catch and thanks for the fix! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants