printf("%.f") should use zero precision, not default precision #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Apr 2, 2017
There was a problem hiding this comment.
Thanks for the PR. Could you please add a test case to printf-test.cc?
|
I added a test for this zero-precision case, and also for the related case with non-zero precision. |
|
The new tests seem to be failing. |
|
Whoops, forgot about rounding... Should be passing now. I actually installed cmake etc. and ran it this time... |
… formatter. fix compilation when custom formatting a type with alignment restrictions (e.g. an sse2 vector type)
|
Merged the first 3 commits (squashed) in cbac016, thanks! The last two commits seem unrelated, please submit as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really minor change to make fmt::printf better conform to the man page when omitting the optional precision digit
An optional period, `.', followed by an optional digit string giving a precision which specifies the number of digits to appear after the decimal point, for e and f formats, or the maximum number of bytes to be printed from a string; if the digit string is missing, the precision is treated as zero;