Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fmt.pro to support build using qmake #641

Merged
merged 3 commits into from
Jan 27, 2018
Merged

Conversation

cowo78
Copy link
Contributor

@cowo78 cowo78 commented Jan 24, 2018

For those who prefer qmake as build system or (my own situation) where it makes sense to bundle fmtlib as 3rd party dependency in a QT project.
The file builds ONLY the library as a STATIC library with DYNAMIC libc runtime.
Tested on Linux/qmake 3.1

@vitaut
Copy link
Contributor

vitaut commented Jan 25, 2018

Thanks for the PR. I'm a bit reluctant to add yet another build config, because it will increase maintenance burden. Is there any reason you cannot use CMake which has native support in Qt Creator?

@cowo78
Copy link
Contributor Author

cowo78 commented Jan 25, 2018

The project I'm talking about is under CI management so we don't always use creator and switching everything to CMake is not an option (at least right now).
Agreed that having multiple build tools is not ideal, but maybe my scenario is not that uncommon.
Maybe move the file off to a contrib/ location or something so that it does not clutter the root while allowing for a starting point for those who are in my situation.

@vitaut
Copy link
Contributor

vitaut commented Jan 25, 2018

Maybe move the file off to a contrib/ location or something so that it does not clutter the root while allowing for a starting point for those who are in my situation.

I think it's a good idea. How about moving fmt.pro to the support directory which already has build management scripts and configs?

@cowo78
Copy link
Contributor Author

cowo78 commented Jan 26, 2018

PR #641 updated

@vitaut vitaut merged commit 0555cea into fmtlib:master Jan 27, 2018
@vitaut
Copy link
Contributor

vitaut commented Jan 27, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants