New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linker errors using fmt as shared library in MSVC #696

Merged

vitaut merged 1 commit into fmtlib:master from sebkoenig:master

Mar 28, 2018

Contributor

sebkoenig commented Mar 28, 2018

When using fmt as a shared library with FMT_SHARED in MSVC, I got linker errors for the library consuming fmt.
Two definitions could not be found:

fmt::internal::error_handler::on_error(const char *message)
char fmt::internal::thousands_sep(locale_provider *lp)

Since those definitions are hidden in format-inl.h I added FMT_API macros to make the functions part of the DLL interface.


          Fix linker errors using fmt as shared library in MSVC

d428d05

vitaut merged commit e90b1da into fmtlib:master

Contributor

vitaut commented Mar 28, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet