fixes MSVC compiler warning bloat (Visual Studio 2017, latest updates) #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, merged! Making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first, thanks for the great library. I am currently porting my own software to Windows and it turned out that MSVC/VS2017 is complaining a lot in my code (99% of the build output is
fmtlib related).It turned out that I could track it down to the following change of this PR.
There might be surely another way (I didn't dig too deep into the template-voodoo of this project), such as the template-ification of
align_spec, so that in line 1144 (wchar_t fill_;) would be more generic. But I'd like to get your feedback, and probably an early merge, so that I do not need to manually patch locally.Best regards,
Christian Parpart.