add support for unsigned long long #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to be able to format the following without any casting
std::cout << fmt::str(fmt::Format("{:x}") << 0xAEull) << std::endl;
std::cout << fmt::str(fmt::Format("{:x}") << 0xAEul) << std::endl;
std::cout << fmt::str(fmt::Format("{:x}") << uint64_t(0xae)) <<
std::endl;
This includes extended error messages which show the original format string. It works for 'char' type with wchar_t returning only the message. The thrown exception class now has a format() method to retrieve the pointer to the original format.
|
Dang it got lumped together |
put the better error message on a separate branch
|
Merged the original commit gcflymoto@225d4f7 to keep the history clean (avoiding "undo" commits). |
Closed
rimathia
pushed a commit
to rimathia/fmt
that referenced
this pull request
Sep 20, 2020
add stb_sprintf to the benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to be able to format the following without any casting
std::cout << fmt::str(fmt::Format("{:x}") << 0xAEull) << std::endl;
std::cout << fmt::str(fmt::Format("{:x}") << 0xAEul) << std::endl;
std::cout << fmt::str(fmt::Format("{:x}") << uint64_t(0xae)) << std::endl;
I believe the last one is already supported. I did not add the tests for this. can't get generated make file from cmake to do anything on linux or work on windows. But was able to compile the VS solution.