Re-enable compile-time format-string checking #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the commit 691a7a9 compile-time string checking was accidently not possible anymore. With this change, it should be possible again.
|
Merged, thanks! |
|
Does this mean compile time format checking isn't in 5.1.0? If so, perhaps this warrants a 5.1.1. |
|
Compile-time format checking is in 5.1.0, only the UDLs are not which is not that important considering that they are non-portable anyway. |
|
But as an example in the spdlog library, the constexpr checking doesn't work without this fix. |
Could you elaborate why it doesn't work with spdlog? The main way of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the commit 691a7a9 compile-time string checking is (accidently?) not possible anymore.
With this change, it should be possible again.