Fix compilation with intel compilers (ICC/ICPC) v14.0 #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Sep 26, 2018
test/format-test.cc
Outdated
| @@ -1577,7 +1577,7 @@ struct explicitly_convertible_to_string_like { | |||
| typename String, | |||
| typename = typename std::enable_if< | |||
| std::is_constructible<String, const char*, std::size_t>::value>::type> | |||
| explicit operator String() const { return String("foo", 3u); } | |||
| operator String() const { return String("foo", 3u); } | |||
There was a problem hiding this comment.
explicit is required here. Please use FMT_EXPLICIT instead.
There was a problem hiding this comment.
Oh, yeah, this makes sense. Corrected!
Luthaf
commented
Sep 26, 2018
| @@ -89,7 +89,8 @@ | |||
| # endif | |||
| #endif | |||
|
|
|||
| #if FMT_HAS_FEATURE(cxx_explicit_conversions) || FMT_MSC_VER >= 1800 | |||
| #if FMT_HAS_FEATURE(cxx_explicit_conversions) || \ | |||
| FMT_GCC_VERSION >= 405 || FMT_MSC_VER >= 1800 | |||
There was a problem hiding this comment.
I used https://en.cppreference.com/w/cpp/compiler_support to check for the GCC version
|
Travis is done, but did not update the commit status, weird =/ |
|
Merged in e864acf, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
autochange was a warningThe
explicitchange was an error