Fix vs2017 warning fmt::v5::localtime 'not all control paths return a value' #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fmt::internal::do_throwworkaround for 'bogus MSVC warning about unreachable code' has a unwanted side effect when using time formatting. It is always my goal to have no warning in my code, but when I building my project (CamStudio fork ) with warning level 4. I get a nicewarning C4715: 'fmt::v5::localtime': not all control paths return a valuewarning. This PR should resolve this issue, although i'm not sure about the fix itself. It feels like adding additional noise.One thing I also tried was to remove the
fmt::internal::do_throwworkaround completely and fix the warnings about unreachable code by removing the unreachable code. But you would have done that already if that would have fixed it.